chore(github): Migrate to renovate GH action #2520
Merged
+104
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilchhofer
requested review from
jmeridth,
pdrastil,
mbevc1,
tico24,
yu-croco and
vladlosev
|
Seems reasonable to switch, but also no strong opinions here. |
mkilchhofer
changed the title
1 task
tico24
reviewed
Feb 23, 2024
tico24
reviewed
Feb 23, 2024
mkilchhofer
force-pushed
the
old_version
branch
6 times, most recently
from
f6c529d
to
59e90e8
Compare
Done. |
mkilchhofer
force-pushed
the
old_version
branch
from
59e90e8
to
bb5effd
Compare
mkilchhofer
changed the title
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
jmeridth
approved these changes
Feb 29, 2024
tico24
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working WIP to replace Renovate hosted app at (https://developer.mend.io/) with a self-hosted version via the official GitHub action renovatebot/github-action.
PR is to start a discussion whether we want to keep the existing approach introduced by @tico24 here:
Status quo
In my point of view it is a bit fragile to synchronize between an App and a GH action. Especially as soon as the GH action adds another commit to update the changelog, Renovate cannot update the PR anymore, otherwise the GH action needs to update the changelog again (unsure whether it works today).
Renovate as a GH action
When we use Renovate as an action, we talk about self-hosted. This ways we are then allowed to execute so-called
postUpgradeTasks. Everything then is under full-control of Renovate.If we proceed
Things which are open to proceed:
Grant same permissions as the official App from MEND
RENOVATE_APP_PRIVATE_KEY)RENOVATE_APP_ID)